[coreboot] [RFC][PATCH] v3: kill duplicated function

Uwe Hermann uwe at hermann-uwe.de
Tue Aug 26 20:06:50 CEST 2008


On Mon, Aug 25, 2008 at 08:03:04PM -0700, ron minnich wrote:
> On Mon, Aug 25, 2008 at 7:54 PM, Carl-Daniel Hailfinger
> > Options:
> > - Kill it in the southbridge code and use mainboard code only.
> 
> maybe.
> 
> > - Make the southbridge one a weak symbol.
> 
> I hate weak symbols :-)
> 
> > - Rename the southbridge one and call it from mainboard code.
> >
> 
> This is very sensible to me.

Ack (if the code is not board-specific; I assume that it's probably not,
or boards can override the generic code if needed).


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list