[coreboot] [PATCH] v3: missing 640k-1024k mem hole for i440bxemulation

[Carl-Daniel Hailfinger]

On 20.03.2008 17:18, Peter Stuge wrote:
> On Wed, Mar 19, 2008 at 09:38:59PM -0700, ron minnich wrote:
>   
>> On Wed, Mar 19, 2008 at 7:39 PM, Carl-Daniel Hailfinger
>> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>>     
>>> i440bxemulation is missing the 640k-1024k mem hole.
>>>  geodelx has the hole.
>>>       
>> I'd like to kill that memory hole.
>>     
>
> +1
>   

What about the hole between 640k and 768k for VGA (0xA0000-0xAFFFF) and
text mode (0xB8000-0xBFFFF)? Doesn't Qemu treat that area specially?

Regards,
Carl-Daniel

Index: corebootv3-stuff2/northbridge/intel/i440bxemulation/i440bx.c
===================================================================
--- corebootv3-stuff2/northbridge/intel/i440bxemulation/i440bx.c	(Revision 794)
+++ corebootv3-stuff2/northbridge/intel/i440bxemulation/i440bx.c	(Arbeitskopie)
@@ -61,8 +61,10 @@
 	mc_dev = dev->link[0].children;
 	if (mc_dev) {
 		idx = 10;
-#warning FIXME: We have no memory hole between 640 and 768 kB
-		ram_resource(dev, idx++, 0, tolmk);
+		/* 0 .. 640 kB */
+		ram_resource(dev, idx++, 0, 640);
+		/* 768 kB .. Systop (in KB) */
+		ram_resource(dev, idx++, 768, tolmk - 768);
 	}
 	phase4_assign_resources(&dev->link[0]);
 }



-- 
http://www.hailfinger.org/