[coreboot] r796 - coreboot-v3/southbridge/amd/cs5536

svn at coreboot.org svn at coreboot.org
Fri Aug 22 02:34:28 CEST 2008


Author: hailfinger
Date: 2008-08-22 02:34:28 +0200 (Fri, 22 Aug 2008)
New Revision: 796

Modified:
   coreboot-v3/southbridge/amd/cs5536/cs5536.c
Log:
CS5536 UART: better depbug prints.

This is the part of the acked patch which was to become r649 but missed
in the check in.
I'm reusing the signoff and ack.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
Acked-by: Stefan Reinauer <stepan at coresystems.de>


Modified: coreboot-v3/southbridge/amd/cs5536/cs5536.c
===================================================================
--- coreboot-v3/southbridge/amd/cs5536/cs5536.c	2008-08-21 19:38:32 UTC (rev 795)
+++ coreboot-v3/southbridge/amd/cs5536/cs5536.c	2008-08-22 00:34:28 UTC (rev 796)
@@ -360,23 +360,26 @@
 		msr = rdmsr(MDD_LEG_IO);
 		msr.lo |= addr << 20;
 		wrmsr(MDD_LEG_IO, msr);
+		printk(BIOS_SPEW, "uarts_init: wrote COM2 address 0x%x\n", sb->com2_address);
 
 		/* Set the IRQ. */
 		msr = rdmsr(MDD_IRQM_YHIGH);
 		msr.lo |= sb->com2_irq << 28;
 		wrmsr(MDD_IRQM_YHIGH, msr);
+		printk(BIOS_SPEW, "uarts_init: set COM2 irq\n");
 
 		/* GPIO3 - UART2_RX */
 		/* Set: Output Enable (0x4) */
 		outl(GPIOL_3_SET, gpio_addr + GPIOL_OUTPUT_ENABLE);
-
+		printk(BIOS_SPEW, "uarts_init: set output enable\n");
 		/* Set: OUTAUX1 Select (0x10) */
 		outl(GPIOL_3_SET, gpio_addr + GPIOL_OUT_AUX1_SELECT);
+		printk(BIOS_SPEW, "uarts_init: set OUTAUX1\n");
 
 		/* GPIO4 - UART2_TX */
 		/* Set: Input Enable (0x20) */
 		outl(GPIOL_4_SET, gpio_addr + GPIOL_INPUT_ENABLE);
-
+		printk(BIOS_SPEW, "uarts_init: set COM2 input enable\n");
 		/* Set: INAUX1 Select (0x34) */
 		/* this totally disables com2 for serial, leave it out until we can
 		 * figure it out
@@ -384,9 +387,10 @@
 //		outl(GPIOL_4_SET, gpio_addr + GPIOL_IN_AUX2_SELECT);
 //		printk(BIOS_SPEW, "uarts_init: set INAUX2 for COM2\n");
 
-		/* Set: GPIO 3 + 3 Pull Up (0x18) */
+		/* Set: GPIO 3 + 4 Pull Up (0x18) */
 		outl(GPIOL_3_SET | GPIOL_4_SET,
 		     gpio_addr + GPIOL_PULLUP_ENABLE);
+		printk(BIOS_SPEW, "uarts_init: set pullup COM2\n");
 
 		/* Enable COM2.
 		 *
@@ -664,6 +668,7 @@
 	lpc_init(sb);
 	uarts_init(sb, dev);
 
+	printk(BIOS_SPEW, "cs5536: done uarts_init\n");
 	if (sb->enable_gpio_int_route) {
 		printk(BIOS_SPEW, "cs5536: call vr_write\n");
 		vr_write((VRC_MISCELLANEOUS << 8) + PCI_INT_AB,





More information about the coreboot mailing list