[coreboot] libpayload misc fixes

Jordan Crouse jordan.crouse at amd.com
Tue Aug 19 19:41:20 CEST 2008


On 19/08/08 19:28 +0200, Stefan Reinauer wrote:
> 
> -- 
> coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
>       Tel.: +49 761 7668825 • Fax: +49 761 7664613
> Email: info at coresystems.dehttp://www.coresystems.de/
> Registergericht: Amtsgericht Freiburg • HRB 7656
> Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
> 

> misc fixes:
> * give struct memrange a name
> * add explicit cast.
> 
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Jordan Crouse <jordan.crouse at amd.com>

> 
> Index: include/sysinfo.h
> ===================================================================
> --- include/sysinfo.h	(revision 3519)
> +++ include/sysinfo.h	(working copy)
> @@ -39,7 +39,7 @@
>  
>  	int n_memranges;
>  
> -	struct {
> +	struct memrange {
>  		unsigned long long base;
>  		unsigned long long size;
>  	} memrange[SYSINFO_MAX_MEM_RANGES];
> Index: drivers/options.c
> ===================================================================
> --- drivers/options.c	(revision 3519)
> +++ drivers/options.c	(working copy)
> @@ -90,7 +90,7 @@
>  	for (   cmos_entry = (struct cb_cmos_entries*)((unsigned char *)option_table + option_table->header_length);
>  		cmos_entry->tag == CB_TAG_OPTION;
>  		cmos_entry = (struct cb_cmos_entries*)((unsigned char *)cmos_entry + cmos_entry->size)) {
> -		if (memcmp(cmos_entry->name, name, len))
> +		if (memcmp((const char*)cmos_entry->name, name, len))
>  			continue;
>  		if(get_cmos_value(cmos_entry->bit, cmos_entry->length, dest))
>  			return 1;

> --
> coreboot mailing list
> coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot


-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.





More information about the coreboot mailing list