[coreboot] v3 K8 impedance mismatch

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Aug 18 16:13:01 CEST 2008


v3 has an interesting impedance mismatch between K8 asm stage0 code and

./arch/x86/amd/stage0.S has this:
	pushl	%ebx  /* init detected */
	pushl	%eax  /* bist */
	call	stage1_main

but arch/x86/stage1.c has this:
 * This function is called from assembler code with its argument on the
 * stack. Force the compiler to generate always correct code for this case.
void __attribute__((stdcall)) stage1_main(u32 bist)

The "init detected" parameter is never touched/used by stage1 code. Do
we need it?

Besides that, the bist parameter seems to refer to the result of the
Built In Self Test, but the comments referring to it in
arch/x86/stage1.c suggest it means something about whether the processor
is the BSP or an AP.



More information about the coreboot mailing list