[coreboot] [PATCH] remove duplicated/unused Makefile rules

Stefan Reinauer stepan at coresystems.de
Sun Aug 17 12:25:56 CEST 2008


Carl-Daniel Hailfinger wrote:
> The decompressors linked into stage0 end up in the variable
> DECOMPRESSORS in arch/x86/Makefile. They absolutely do no belong there
> because they're not arch specific.
> lib/Makefile has a variable COMPRESSORS with identical content, but that
> variable is completely unused. Move DECOMPRESSORS to lib/Makefile and
> kill the unused one.
>
> Build and boot tested on qemu.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>   
Acked-by: Stefan Reinauer <stepan at coresystems.de>
> Index: corebootv3-makefile_compression_fix/lib/Makefile
> ===================================================================
> --- corebootv3-makefile_compression_fix/lib/Makefile	(Revision 777)
> +++ corebootv3-makefile_compression_fix/lib/Makefile	(Arbeitskopie)
> @@ -19,12 +19,12 @@
>  ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>  ##
>  
> -COMPRESSORS :=
> +DECOMPRESSORS :=
>  ifeq ($(CONFIG_COMPRESSION_LZMA),y)
> -COMPRESSORS += lzma.o
> +DECOMPRESSORS += lzma.o
>  endif
>  ifeq ($(CONFIG_COMPRESSION_NRV2B),y)
> -COMPRESSORS += nrv2b.o
> +DECOMPRESSORS += nrv2b.o
>  endif
>  
>  #
> Index: corebootv3-makefile_compression_fix/arch/x86/Makefile
> ===================================================================
> --- corebootv3-makefile_compression_fix/arch/x86/Makefile	(Revision 777)
> +++ corebootv3-makefile_compression_fix/arch/x86/Makefile	(Arbeitskopie)
> @@ -39,14 +39,6 @@
>  LARFILES_NOCOMPRESS := coreboot.initram:normal/initram option_table:normal/option_table
>  LARFILES_COMPRESSIBLE := coreboot.stage2:normal/stage2
>  
> -DECOMPRESSORS :=
> -ifeq ($(CONFIG_COMPRESSION_LZMA),y)
> -DECOMPRESSORS += lzma.o
> -endif
> -ifeq ($(CONFIG_COMPRESSION_NRV2B),y)
> -DECOMPRESSORS += nrv2b.o
> -endif
> -
>  COMPRESSFLAG :=
>  ifeq ($(CONFIG_DEFAULT_COMPRESSION_LZMA),y)
>  COMPRESSFLAG := -C lzma
>
>
>   


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866





More information about the coreboot mailing list