[coreboot] last for the day

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Aug 11 15:46:13 CEST 2008


On 11.08.2008 15:29, Mart Raudsepp wrote:
> Ühel kenal päeval, P, 2008-08-10 kell 15:03, kirjutas ron minnich:
>   
>> On Sun, Aug 10, 2008 at 2:45 PM, Carl-Daniel Hailfinger wrote:
>>     
>>> On 10.08.2008 23:25, ron minnich wrote:
>>>       
>>>> This patch is for include/ to add k8 includes.
>>>>
>>>> ron
>>>>
>>>> Add defines for K8
>>>>
>>>> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
>>>>         
>>> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>>       
>> Committed revision 732.
>>     
>
> This broke the build of all GeodeLX targets, because the define of
> PCI_DEVICE_ID_AMD_LXBRIDGE lost a newline before it and got to the same
> line as PCI_DEVICE_ID_AMD_VIPER_7412 - including in the reviewed
> attachment.
>   

My apologies. I try to review as well as possible and it seems I
overlooked that.

Thanks for fixing this!

Regards,
Carl-Daniel




More information about the coreboot mailing list