[coreboot] [PATCH] coreinfo: ramdump_module garbage

Ulf Jordan jordan at chalmers.se
Sat Aug 9 12:07:27 CEST 2008


Hello!

The attached patch fixes the garbage characters seen instead of vertical 
bars in the coreinfo ramdump_module screen. Compile tested against r3478 
and runtime tested with coreinfo+coreboot-v3 in QEMU.

/ulf
-------------- next part --------------
Fix garbage characters on screen. mvwaddch inserts one character,
not a character array.

Signed-off-by: Ulf Jordan <jordan at chalmers.se>

Index: coreinfo/ramdump_module.c
===================================================================
--- coreinfo/ramdump_module.c	(revision 3478)
+++ coreinfo/ramdump_module.c	(arbetskopia)
@@ -40,8 +40,8 @@
 	for (i = 1; i < 257; i++) {
 		if (x == 0) {
 			mvwprintw(win, row + y, col - 1, "%08x", addr + 16 * y);
-			mvwaddch(win, row + y, col + 59, (const chtype)"|");
-			mvwaddch(win, row + y, col + 76, (const chtype)"|");
+			mvwaddch(win, row + y, col + 59, '|');
+			mvwaddch(win, row + y, col + 76, '|');
 		}
 		mvwprintw(win, row + y, col + x + 9, "%02x", ptr[i - 1]);
 		mvwprintw(win, row + y, 62 + count++, "%c", ptr[i - 1]);


More information about the coreboot mailing list