[coreboot] [flashrom] convert lb_ to cb_

Sean Nelson snelson at nmt.edu
Fri Aug 8 23:31:02 CEST 2008


removed (C)

On Fri, Aug 8, 2008 at 2:11 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> On Fri, Aug 08, 2008 at 10:21:55PM +0200, Peter Stuge wrote:
>> On Fri, Aug 08, 2008 at 10:00:39AM -0700, Sean Nelson wrote:
>> > -static inline uint64_t unpack_lb64(struct lb_uint64 value)
>> > +static inline uint64_t unpack_lb64(struct cb_uint64 value)
>> >  {
>>
>> You missed the function names, but the rest looks good.
>>
>> Can you send a new patch with that fixed?
>
> Also, I'd rather not add an additional (C) for this patch, simple
> "fix typo"- or "whitespace-fixes"-style patches such as this don't
> warrant adding a (C) to the code (IMHO). (the other parts of your
> flashrom changes do, of course, as they're non-cosmetic and
> non-trivial).
>
>
> Uwe.
> --
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
>
> --
> coreboot mailing list
> coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lb-to-cb-flashrom3.patch
Type: application/octet-stream
Size: 15350 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080808/41341721/attachment.obj>


More information about the coreboot mailing list