[coreboot] [flashrom] covert to coreboot's pci function style, add libpayload compile support; makefile needs some work

Uwe Hermann uwe at hermann-uwe.de
Fri Aug 8 10:18:46 CEST 2008


On Thu, Aug 07, 2008 at 09:38:11PM -0700, Sean Nelson wrote:
> Flashrom patched for compiling with libpayload while still being able
> to compile with libpciutil; uses coreboot styled pci function names
> found in libpayload.
> 
> Signed-off-by: Sean Nelson <snelson at nmt.edu>

Nice, thanks.

Not much time now, will post a detailed review later this day, but one
thing I've seen so far: please post an extra patch against flashrom
proper to change "lb_" to "cb_", this issue is independent of any
libpayload involvement and should be an extra patch.

More comments later.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list