[coreboot] patch: k8 support in v3.
ron minnich
rminnich at gmail.com
Fri Aug 1 19:04:51 CEST 2008
On Fri, Aug 1, 2008 at 9:50 AM, Marc Jones <Marc.Jones at amd.com> wrote:
>
>> -#endif /* ARCH_X86_MTRR_H */
>> Index: arch/x86/Makefile
>> ===================================================================
>> --- arch/x86/Makefile (revision 699)
>> +++ arch/x86/Makefile (working copy)
>> @@ -124,9 +124,12 @@
>> STAGE0_ARCH_X86_OBJ += geodelx/stage1.o
>> STAGE0_ARCH_X86_OBJ += ../../northbridge/amd/geodelx/geodelxinit.o
>> else
>> - STAGE0_CAR_OBJ = stage0_i586.o
>> +ifeq ($(CONFIG_CPU_AMD_K8),y)
>> + STAGE0_CAR_OBJ = amd/stage0.o
>> + STAGE0_ARCH_X86_OBJ += amdk8/stage1.o
>> endif
>> endif
>> +endif
>
> Add else and put the stage0_i586 on the end?
I took it out. There should be a valid value for the CPU. anything
else is an error. This mistake bit me so I don't want it getting
anyone else.
>
> I agree with getting the pieces in place as we go.
> The files looked fine to me but I didn't try to build it.....
>
> Acked-by: Marc Jones <marc.jones at amd.com>
Committed revision 702.
I added gigabyte/Kconfig per peter's note.
ron
More information about the coreboot
mailing list