[coreboot] r3458 - trunk/coreboot-v2/src/devices

svn at coreboot.org svn at coreboot.org
Fri Aug 1 14:28:40 CEST 2008


Author: stepan
Date: 2008-08-01 14:28:38 +0200 (Fri, 01 Aug 2008)
New Revision: 3458

Modified:
   trunk/coreboot-v2/src/devices/device.c
Log:
clarify in the printks what function is actually called. This little smart magic
drove me crazy during debugging. Fix Typos. Add a warning because the
on-chipset devices are hardcoded. For newer machines, a lot more memory space
will have special meanings, and we can't hardcode them all in an ifdef desert.

(trivial)

Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>



Modified: trunk/coreboot-v2/src/devices/device.c
===================================================================
--- trunk/coreboot-v2/src/devices/device.c	2008-08-01 12:20:26 UTC (rev 3457)
+++ trunk/coreboot-v2/src/devices/device.c	2008-08-01 12:28:38 UTC (rev 3458)
@@ -272,7 +272,7 @@
 	min_align = 0;
 	base = bridge->base;
 
-	printk_spew("%s compute_allocate_%s: base: %08Lx size: %08Lx align: %d gran: %d\n", 
+	printk_spew("%s compute_allocate_resource %s: base: %08Lx size: %08Lx align: %d gran: %d\n", 
 		dev_path(bus->dev),
 		(bridge->flags & IORESOURCE_IO)? "io":
 		(bridge->flags & IORESOURCE_PREFETCH)? "prefmem" : "mem",
@@ -312,7 +312,7 @@
 			align = min_align;
 		}
 
-		/* Propogate the resource alignment to the bridge register  */
+		/* Propagate the resource alignment to the bridge register  */
 		if (align > bridge->align) {
 			bridge->align = align;
 		}
@@ -325,10 +325,12 @@
 		if (bridge->limit > resource->limit) {
 			bridge->limit = resource->limit;
 		}
+#warning This heuristics should be replaced by real devices with fixed resources.
 		/* Artificially deny limits between DEVICE_MEM_HIGH and 0xffffffff */
 		if ((bridge->limit > DEVICE_MEM_HIGH) && (bridge->limit <= 0xffffffff)) {
 			bridge->limit = DEVICE_MEM_HIGH;
 		}
+
 		if (resource->flags & IORESOURCE_IO) {
 			/* Don't allow potential aliases over the
 			 * legacy pci expansion card addresses.
@@ -373,7 +375,7 @@
 	 */
 	bridge->size = round(base, bridge->gran) - bridge->base;
 
-	printk_spew("%s compute_allocate_%s: base: %08Lx size: %08Lx align: %d gran: %d done\n", 
+	printk_spew("%s compute_allocate_resource %s: base: %08Lx size: %08Lx align: %d gran: %d done\n", 
 		dev_path(bus->dev),
 		(bridge->flags & IORESOURCE_IO)? "io":
 		(bridge->flags & IORESOURCE_PREFETCH)? "prefmem" : "mem",
@@ -633,7 +635,7 @@
  * relocated to their final position and stored to the hardware.
  *
  * I/O resources start at DEVICE_IO_START and grow upward. MEM resources start
- * at DEVICE_MEM_START and grow downward.
+ * at DEVICE_MEM_HIGH and grow downward.
  *
  * Since the assignment is hierarchical we set the values into the dev_root
  * struct. 





More information about the coreboot mailing list