[coreboot] buildrom bug

Jordan Crouse jordan.crouse at amd.com
Mon Apr 28 17:46:40 CEST 2008


On 28/04/08 09:40 -0600, Myles Watson wrote:
> > > > @@ -31,13 +35,19 @@
> > > >  $(GEODE_PADDED_VSA): $(GEODE_COMPRESSED_VSA)
> > > >  	@ cp $< $@
> > > >  	@ (size=`stat -c %s $<`; count=`expr $(GEODE_VSA_SIZE) - $$size`; \
> > > > -	@ dd if=/dev/zero bs=1 count=$$count  >> $@ 2> /dev/null)
> > > > +	dd if=/dev/zero bs=1 count=$$count  >> $@ 2> /dev/null)
> > >
> > > On purpose?
> > yes - the @ is a makeism - the second @ was in the shell and freaking
> > out sh.
> 
> Can you indent the dd so that it's obvious that it's part of the previous
> line?

Yep, not a problem.  Isn't shell inside of Make grand? </sarcasm>

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.





More information about the coreboot mailing list