[coreboot] Patch for ST M50FLW080A support
Peter Stuge
peter at stuge.se
Fri Apr 25 20:46:43 CEST 2008
Hello Claus,
On Fri, Apr 25, 2008 at 02:52:46PM +0200, Claus Gindhart wrote:
> The information contained in this document is CONFIDENTIAL and
> property of Kontron.
> Any unauthorized review, use, disclosure or distribution is
> prohibited without express written consent of Kontron.
Again, please discuss these sentences with your employer.
> Index: jedec.c
> ===================================================================
Your patch looks good after a quick review - except that it seems to
include quite a bit of what seems to be experimental code in jedec.c
that probably was not meant to be committed.
> +int write_page_stm50flw0x0x(volatile uint8_t *bios, uint8_t *src,
> + volatile uint8_t *dst, int page_size)
> +{
..
> +/* claus.gindhart at kontron.com
> + * TODO
> + * I think, that verification is not required, but
> + * i leave it in anyway
> + */
> + dst = d;
> + src = s;
> + for (i = 0; i < page_size; i++) {
> + if (*dst != *src) {
> + rc = -1;
> + break;
> + }
> + dst++;
> + src++;
> + }
You are correct - verification is done in other functions in flashrom
so please remove it from the write function.
On Fri, Apr 25, 2008 at 03:52:57PM +0200, Paul Menzel wrote:
> I think you have to add a Signed-Off-By line [1]. Otherwise your
> patch cannot be acked and then commited.
>
> [1] http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
Spot on, Paul.
Claus, please have a look at the development guidelines page which
describes the (simple) process for contributing code to the project.
Part of that is the sign-off procedure that Paul mentions.
It is important that all contributions come with an unambiguous
license, which is why I am so repetitive about the automatic
disclaimer in your outgoing email. I am sorry for the extra trouble.
Ideally you would be able to remove that text from your outgoing
email messages at least to this mailing list.
Best regards
//Peter
More information about the coreboot
mailing list