[coreboot] buildrom bug

[Myles Watson]

On Fri, Apr 25, 2008 at 10:54 AM, Jordan Crouse <jordan.crouse at amd.com> wrote:
>
> On 25/04/08 10:13 -0600, Myles Watson wrote:
>  >
>  >
>  > > -----Original Message-----
>  > > From: coreboot-bounces at coreboot.org [mailto:coreboot-bounces at coreboot.org]
>  > > On Behalf Of Jordan Crouse
>  > > Sent: Friday, April 25, 2008 9:40 AM
>  > > To: Myles Watson; coreboot at coreboot.org
>  > > Subject: Re: [coreboot] buildrom bug
>  > >
>  > > On 25/04/08 11:37 -0400, Ward Vandewege wrote:
>  > > > On Fri, Apr 25, 2008 at 09:20:23AM -0600, Myles Watson wrote:
>  > > > > > Don't we need that PAYLOAD_AND_DEP_MK change for every payload?
>  > > > >
>  > > > > Did I miss one?  Most of the payloads don't have dependencies.  The
>  > > > > libpayload ones were the only ones I saw.
>  > > >
>  > > > The LAB and kernel payloads?

You're right.  I've included them in this patch.

>  > > > > > +include $(PACKAGE_DIR)/utils/nrv2b.mk
>  > > > >
>  > > > > Yep, I missed that one.  Fixed.
>  > > >
>  > > > Great.
>  > > >
>  > > > > > This also brings up the question why nrv2b.mk is in the 'utils'
>  > > directory,
>  > > > > > instead of the $(PACKAGE_DIR)/nrv2b/ directory?
>  > > > >
>  > > > > Because it doesn't get included in the ROM?
>  > > >
>  > > > Hmm, ok, yes.
>  > >
>  > > I guess it all depends on how many directories we want to look at,
>  > > and trade that off with how complex the scripts should be.  I don't
>  > > really have an opinion one way or the other on that.
>  >
>  > I'm happy to move it.  I was just speculating on the original reason it was
>  > there.  Unfortunately, lzma is in $(PACKAGE_DIR)/lzma/, which shoots down my
>  > theory.  I think that we should avoid automagically including make files.
>  > There are few enough of them that we should only include specific ones to
>  > avoid problems.
>
>  Your mistake is that you assumed that we (I) followed any specific plan. :)

If we could only see the future... design would be so much easier.

>  Yes, go ahead and move them where ever you think they work the best,
>  and ack on the including make files comment.

Here's the updated patch.  It needs to be preceded by
svn mv packages/utils packages/nrv2b

Signed-off-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles
-------------- next part --------------
A non-text attachment was scrubbed...
Name: payload_handling.patch
Type: text/x-patch
Size: 3303 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080425/9cba9d67/attachment.patch>