[coreboot] [PATCH] fix all s2891 sata ports

[Ward Vandewege]

On Wed, Apr 23, 2008 at 11:26:32AM -0600, Myles Watson wrote:
> On Tue, Apr 22, 2008 at 6:49 PM, Ward Vandewege <ward at gnu.org> wrote:
> > On Tue, Apr 22, 2008 at 04:56:19PM -0600, Myles Watson wrote:
> >  > It works for me after applying the mptable fix for the s2892.  It now
> >  > sees a SATA port that it didn't used to.  Thanks.
> >  >
> >
> > > Acked-by: Myles Watson <mylesgw at gmail.com>
> >
> >  Thanks, r3253.
> >
> >
> >  > I don't have an s2891 to try it on.  Are there other boards we should
> >  > apply the fix to?  s2895 etc.
> >
> >  From the looks of it, these boards have the same bug:
> >
> >   tyan s2892
> >   tyan s2895
> >   sun ultra40
> >
> >  Since you've already tested an s2892, I'd be happy to supply a patch and you
> >  can ack it? Same for s2895 - you have that hardware right?
> 
> Here's the patch for the s2892 that I used.  When my s2895 has some
> down time I'll can check it.  I'd feel fine about just committing it
> since it uses the same chipset and has the same problem.

Yeah. I agree. Want to make a patch?

> Signed-off-by: Myles Watson <mylesgw at gmail.com>

Acked-by: Ward Vandewege <ward at gnu.org>

And committed in r3255.

> I haven't. It's too bad you can't turn off multimode in the
> proprietary BIOS to see if that's really the issue

Yeah. I'm not sure it is. But *something* is going on here. If you get a
chance to run bonnie++ on your various other ck804 boards, that would be
great for comparison.

Thanks,
Ward.

-- 
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior System Administrator