[coreboot] libpayload: add gettimeofday()
Jordan Crouse
jordan.crouse at amd.com
Mon Apr 21 21:38:51 CEST 2008
On 21/04/08 21:02 +0200, Uwe Hermann wrote:
> > + /* Instead of finding the century register,
> > + we just make an assumption that if the year value is
> > + less then 80, then it is 2000+
> > + */
>
> I'd add a FIXME or TODO here :)
*is* it a TODO? The century register is implementation dependent.
This is not a 5 9s OS here, and I would pefer simple over complex
#ifdefs. Or not?
> > @@ -30,9 +30,9 @@
> > #ifndef _ARCH_RDTSC_H
> > #define _ARCH_RDTSC_H
> >
> > -static inline unsigned long long rdtsc(void)
> > +static inline u64 rdtsc(void)
> > {
> > - unsigned long long val;
> > + u64 val;
>
> Yep.
>
> Can the inline be removed as well or is it required here?
No - for modern compilers, we should go ahead and remove inlines
everywhere.
Jordan
More information about the coreboot
mailing list