[coreboot] r3236 - in trunk/payloads/libpayload: include libc

[a a]

Ulf Jordan wrote:
> On Fri, 11 Apr 2008, svn at coreboot.org wrote:
> 
>> +int isxdigit(int c)
>> +{
>> +	return isdigit(c) || (tolower(c)>= 'a' && tolower(c) <= 'z');
>> +}
> 
> Shouldn't this be
> 
> return isdigit(c) || (tolower(c)>= 'a' && tolower(c) <= 'f');
jep it should..
but why not :
  return isdigit(c) || c>= 'a' && c <= 'f' || c>= 'A' && c <= 'F' );
it might be even faster if you do
return isdigit(c) || (c & ~0x20)>= 'A' && (c & ~0x20) <= 'F' );
> 
> 
> /ulf
> 



_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080411/34190c57/attachment.html>