[coreboot] [3/3] [buildrom]: Add coreinfo to buildrom
Ward Vandewege
ward at gnu.org
Fri Apr 11 21:53:16 CEST 2008
On Thu, Apr 10, 2008 at 04:45:20PM -0600, Jordan Crouse wrote:
> Patch 3 of 3 - add coreinfo to buildrom. Yay!
>
>
> !DSPAM:47fe974377151804284693!
> [buildrom]: Add coreinfo to buildrom
>
> Signed-off-by: Jordan Crouse <jordan.crouse at amd.com>
Acked-by: Ward Vandewege <ward at gnu.org>
(but see a few changes below)
> Index: buildrom-devel/packages/coreinfo/coreinfo.mk
> +$(COREINFO_SRC_DIR)/.config: $(COREINFO_STAMP_DIR)/.unpacked
> + @ cp $(COREINFO_CONFIG) $@
> + @ make -C $(COREINFO_SRC_DIR) oldconfig
Please change this to
@ make -C $(COREINFO_SRC_DIR) oldconfig > $(COREINFO_BUILD_LOG) 2>&1
> +
> +$(COREINFO_SRC_DIR)/build/coreinfo.elf: $(COREINFO_SRC_DIR)/.config
> + @ echo "Building coreinfo..."
> + @ make -C $(COREINFO_SRC_DIR) LIBPAYLOAD_DIR=$(STAGING_DIR)/libpayload
Please change this to
@ make -C $(COREINFO_SRC_DIR) LIBPAYLOAD_DIR=$(STAGING_DIR)/libpayload >
$(COREINFO_BUILD_LOG) 2>&1
> +$(COREINFO_STAMP_DIR)/.copied: $(COREINFO_SRC_DIR)/build/coreinfo.elf
> + mkdir -p $(shell dirname $(PAYLOAD_ELF))
> + cp $(COREINFO_SRC_DIR)/build/coreinfo.elf $(PAYLOAD_ELF)
Please add @ at the start of those two lines.
> + @ touch $@
Thanks,
Ward.
--
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior System Administrator
More information about the coreboot
mailing list