[coreboot] [2/3] buildrom: Add support for libpayload as a dependency

Uwe Hermann uwe at hermann-uwe.de
Fri Apr 11 01:23:49 CEST 2008


I'll let the usual suspects review and ACK buildrom code, just some
small notes:

On Thu, Apr 10, 2008 at 04:43:20PM -0600, Jordan Crouse wrote:
> Index: buildrom-devel/packages/libpayload/libpayload.mk
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/packages/libpayload/libpayload.mk	2008-04-10 13:03:02.000000000 -0600
> @@ -0,0 +1,88 @@
[...]
> +ifeq ($(call custom-config-exists,libpayload), 1)
> +LIBPAYLOAD_CONFIG=$(call custom-config-name,libpayload)
> +else
> +ifeq ($(CONFIG_PLATFORM_GEODE),y)
> +LIBPAYLOAD_CONFIG=$(PACKAGE_DIR)/libpayload/conf/defconfig
> +else
> +LIBPAYLOAD_CONFIG=$(PACKAGE_DIR)/libpayload/conf/defconfig.geode

Isn't the logic here inverted? Untested, but I'd assume the
"defconfig.geode" would belong to the "CONFIG_PLATFORM_GEODE=y" part?


> +libpayload-config: | $(LIBPAYLOAD_SRC_DIR)/.config

Does this work? The '|' there looks strange, but maybe I'm missing
something.


> +ifeq ($(call custom-config-exists,libpayload), 1)
> +	@ cp -f $(call custom-config-name,libpayload) $(LIBPAYLOAD_SRC_DIR)/.config
> +endif
> +	@ echo "Configure libpayload..."
> +	@ $(MAKE) -C $(LIBPAYLOAD_SRC_DIR) menuconfig
> +	@ echo
> +ifeq ($(call custom-config-exists,libpayload),1)
> +	@ echo "Found an existing custom configuration file:"
> +	@ echo "  $(call custom-config-name,libpayload)"
> +	@ echo "I've copied it back to the source directory for modification."
> +	@ echo "Remove the above file and re-run this comand if you want to create a new customer configuration from scratch for this payload/board."

comand -> command


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list