[coreboot] [patch][v2] AMD Fam10 memory controller updates

[Marc Jones]

Peter Stuge wrote:
> On Mon, Apr 07, 2008 at 03:06:29PM -0600, Marc Jones wrote:
>   
>> Bring Fam10 memory controller init up to date with the latest AMD BKDG
>> recomendations.
>>
>> Changes include the following:
>> fix > 4GB dqs tests
>> fix channel interleaving
>> fix memory hoisting across nodes
>> ecc memory scrub updates
>> debug print changes
>> minor cleanups
>>
>> Signed-off-by: Marc Jones (marc.jones at amd.com)
>>     
>
> NAK.
>
>
>   
>> Index: coreboot-v2/src/northbridge/amd/amdmct/mct/mct_d.c
>> ===================================================================
>> --- coreboot-v2.orig/src/northbridge/amd/amdmct/mct/mct_d.c	2008-04-07 11:28:02.000000000 -0600
>> +++ coreboot-v2/src/northbridge/amd/amdmct/mct/mct_d.c	2008-04-07 14:45:52.000000000 -0600
>> @@ -1,7 +1,7 @@
>>  /*
>>   * This file is part of the coreboot project.
>>   *
>> - * Copyright (C) 2007 Advanced Micro Devices, Inc.
>> + * Copyright (C) 2007-2008  Advanced Micro Devices, Inc.
>>   *
>>   * This program is free software; you can redistribute it and/or modify
>>   * it under the terms of the GNU General Public License as published by
>> @@ -277,12 +277,15 @@
>>  	mctHookAfterCPU();			/* Setup external northbridge(s) */
>>  
>>  	print_t("mctAutoInitMCT_D: DQSTiming_D\n");
>> -	DQSTiming_D(pMCTstat, pDCTstatA);	/* Get Receiver Enable and DQS signal timing*/
>> +	DQSTiming_D(pMCTstat, pDCTstatA);	/* Get Receiver Enable and DQS signal timing */
>> +
>> +	print_t("mctAutoInitMCT_D: UMAMemTyping_D\n");
>> +	UMAMemTyping_D(pMCTstat, pDCTstatA);	/* Fix up for UMA sizing */
>>     
>
> Please keep code changes and whitespace changes apart. In particular
> when changing things like these (that are not very well known) I
> think that is important.
>
>   
Serious? You are naking over a couple whitespace changes that get fixed 
as the code is fixed? Do you have concerns that the patch is confused by 
the changes or are you just naking on principal?

Marc

-- 
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors