[coreboot] v2[PATCH]ICH series halt tco timer

joe at smittys.pointclark.net joe at smittys.pointclark.net
Sun Apr 6 06:29:07 CEST 2008


Quoting Corey Osgood <corey.osgood at gmail.com>:

> On Sat, Apr 5, 2008 at 11:38 PM, <joe at smittys.pointclark.net> wrote:
>
>>
>>  PMBASE_ADDR can be anywhere we want it to be, so long as it doesn't
>> > collide
>> > with any IO addresses that have been reserved for other things.
>> > Currently,
>> > it's defined in i82801xx_lpc.c at the same address, that's why I was
>> > saying
>> > to move those defines as well (so PMBASE_ADDR isn't defined in 2
>> > different
>> > places). If PMBASE_ADDR ever needs to be somewhere else for some reason
>> > in
>> > the future, we can make it configurable at build time (or something).
>> >
>> > -Corey
>> >
>> >  Ok, here is the revised patch.
>>
>>
>> Signed-off-by: Joseph Smith <joe at smittys.pointclark.net>
>>
>>
>> Thanks - Joe
>>
>
> Acked-by: Corey Osgood <corey.osgood at gmail.com>
>

r3218

Thanks - Joe




More information about the coreboot mailing list