[LinuxBIOS] [PATCH] v3: lar header walk off-by-one

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Sep 28 15:39:14 CEST 2007

On 28.09.2007 15:33, Uwe Hermann wrote:
> On Thu, Sep 27, 2007 at 10:19:57AM -0700, ron minnich wrote:
>> OK, I like signed offset, but let's let stefan weigh in. It's critical
>> that we get this right.
> I don't have any particular opinion here, but I'll NACK the patch in
> this form. If everybody else agrees with the patch _and_ there are at least
> 3-4 lines of code comments which explain all the issues involved here, the
> drawbacks and advantages of this (and the alternative) solution(s) etc.,
> I'll be happy to ACK :) As already stated, this is way too tricky and
> non-obvious to go in without a good code comment.

I'll add a detailed writeup and remove incorrect comments so that the
comments match the code again.


More information about the coreboot mailing list