[LinuxBIOS] [PATCH] Build fix for MSI MS-6178

Corey Osgood corey.osgood at gmail.com
Thu Sep 13 05:17:23 CEST 2007


Uwe Hermann wrote:
> See patch.
>
> In addition to _this_ patch, my failover.c patch (no ACKs yet) needs to
> be committed, too, to really fix the build.
>
>
> Uwe.
>   

Both patches (I don't want to dig for the failover.c patch but I'm
familiar with it):
Acked-by: Corey Osgood <corey.osgood at gmail.com>

1 comment below ;)

> ------------------------------------------------------------------------
>
> Fix the build for the MSI MS-6178 target (wrong location of the common
> failover.c file).
>
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
>
> Index: src/mainboard/msi/ms6178/Config.lb
> ===================================================================
> --- src/mainboard/msi/ms6178/Config.lb	(Revision 2771)
> +++ src/mainboard/msi/ms6178/Config.lb	(Arbeitskopie)
> @@ -35,12 +35,12 @@
>  if HAVE_PIRQ_TABLE object irq_tables.o end
>  # object reset.o
>  makerule ./failover.E
> -	depends "$(MAINBOARD)/../../../lib/failover.c ./romcc"
> -	action "./romcc -E -O --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(MAINBOARD)/../../../lib/failover.c -o $@"
> +	depends "$(MAINBOARD)/../../../arch/i386/lib/failover.c ./romcc"
>   

Is there really no simpler way of stating this line?

> +	action "./romcc -E -O --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(MAINBOARD)/../../../arch/i386/lib/failover.c -o $@"
>  end
>  makerule ./failover.inc
> -	depends "$(MAINBOARD)/../../../lib/failover.c ./romcc"
> -	action "./romcc    -O --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(MAINBOARD)/../../../lib/failover.c -o $@"
> +	depends "$(MAINBOARD)/../../../arch/i386/lib/failover.c ./romcc"
> +	action "./romcc    -O --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(MAINBOARD)/../../../arch/i386/lib/failover.c -o $@"
>  end
>  makerule ./auto.E
>  	# depends "$(MAINBOARD)/auto.c option_table.h ./romcc"
>   





More information about the coreboot mailing list