[LinuxBIOS] [PATCH] Flashrom: sis630 simplification

Uwe Hermann uwe at hermann-uwe.de
Tue Sep 11 17:59:42 CEST 2007

On Tue, Sep 11, 2007 at 11:53:58AM +0200, Stefan Reinauer wrote:
> * Li-Ta Lo <ollie at lanl.gov> [070910 19:24]:
> > > I'm not too eager to find out the hard way. This is low-level
> > > enough that I think there _might_ be unintended/unnoticed consequences.
> > > 
> > > Anybody with such a chipset willing to test the patch?
> > 
> > It was too long ago for me to remember why I was doing something like 
> > that. My guess is that the pci_dev passed to the function is the 
> > northbridge but you have to program the southbridge or the LPC or it
> > was not linked with pci_util then.
> Not linking against libpci was indeed the issue that caused this. 
> I think we should check the code in like that. 

OK then, r2770.

It would still be nice if somebody could test this on hardware, though.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070911/0d2dece6/attachment.sig>

More information about the coreboot mailing list