[LinuxBIOS] [PATCH] Flashrom: sis630 simplification

Uwe Hermann uwe at hermann-uwe.de
Sun Sep 9 22:11:57 CEST 2007

On Sat, Sep 08, 2007 at 08:41:18PM +0200, Peter Stuge wrote:
> On Sat, Sep 08, 2007 at 07:56:32PM +0200, Uwe Hermann wrote:
> > On Sat, Sep 08, 2007 at 04:49:46PM +0200, Alex Beregszaszi wrote:
> > > attached patch changes out/in combinations to pci_read/write_byte in
> > > sis630 chipset enable.
> > 
> > Why?
> There is abstraction available - so it should be used everywhere.

Ah, yes. I missed the fact that those functions do the same as the
replaced code.

> > Did you test the patch on hardware?
> On Sat, Sep 08, 2007 at 10:59:39AM -0700, ron minnich wrote:
> > I don't think this should be done unless someone can test.
> I agree with the patch - I want the change, but I also agree it would
> be nice to have it tested.
> We could argue that we decided to go through with the patch in order
> to improve the code and until someone has a problem with the code not
> working there is no real problem.

I'm not too eager to find out the hard way. This is low-level
enough that I think there _might_ be unintended/unnoticed consequences.

Anybody with such a chipset willing to test the patch?

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070909/26cee478/attachment.sig>

More information about the coreboot mailing list