[LinuxBIOS] [PATCH] LAR compression in xip not supported

Alex Beregszaszi alex at rtfs.hu
Wed Sep 5 18:07:54 CEST 2007


On Tue, 2007-09-04 at 20:19 -0700, ron minnich wrote:
> On 9/4/07, Alex Beregszaszi <alex at rtfs.hu> wrote:
> > Hi,
> >
> > attached patch returns if someone tries to execute in place a compressed
> > entry.
> >
> This is a must never happen. If the lar tool ever creates this, it has
> seriously screwed up. We need to make sure the lar tool can not set
> both compression and XIP.

LAR doesn't has a field for telling that an entry will be XIP or not.
Whether we run it in place or move it is only our _runtime_ decision,
thus this check is needed.

If you mean that the LAR tool should check for mandatory names (like
initram) which can't be compressed, well, that is handled in the
makefiles (see nocompress:normal/initram).

I think such an extra check wouldn't hurt (maybe if you care about
space, you could merge some checks to print only one message).


More information about the coreboot mailing list