[LinuxBIOS] r2758 - in trunk: LinuxBIOSv2/util util

Stefan Reinauer stepan at coresystems.de
Wed Sep 5 01:52:57 CEST 2007

* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [070903 20:36]:
> This commit removed probe_superio from v2. It has not been referenced as
> svn:externals, so none of the v2 and v3 trees have probe_superio or
> superiotool.
> As of revision 2762, the v2 repository is still BROKEN and superiotool
> doesn't appear in v3 either (checked revision 486).
> Such commits are one reason why I think self-acked commits should not be
> allowed.

Well. Half-hearted code reviews are an illusion of safety, too.

The current code's lar handling is pretty much broken even though that
code was reviewed, but obviously nobody even tested it:

Wrote LinuxBIOS table at: 0x00000500 - 0x00000a54  checksum 401f
Show all devs...
cpus: Unknown device path type: 0
Stage2 code done.
LAR: Attempting to open 'normal/payload'.
LAR: Attempting to open 'normal/payload/segment0'.
LAR: load_file: No such file 'normal/payload/segment0'

It just hangs somewhere bogus and never gets to the defined error in 

  arch/x86/stage1.c:194: die("FATAL: No usable payload found.\n");

also the current code contains quite some warnings again regarding
int-to-pointer casts in lar.c and pointer-to-int cast and uninitialized
variable use in stage1.c


coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/

More information about the coreboot mailing list