[LinuxBIOS] [PATCH] Intel 82371EB: IDE init support (or: S1846 boots Linux kernel)

[Corey Osgood]

Uwe Hermann wrote:
> Here's a patch which adds IDE support to the Intel 82371EB southbridge.
> 
> With this patch I can boot a Linux kernel with FILO up until the login
> prompt. I can login and use the system, too. Feels a bit slowish, but
> maybe that's just because the CPU and disk are dead slow...
> 
> (Hm, there's an "Enable Ultra DMA/33" setting on the IDE controller --
> should I enable that in the southbridge code, or can Linux do that and
> it's superfluous in the BIOS?)
> 
> Anyway, this patch also fixes random other southbridge files, and I'm
> adding my copyright header to some other files as they're either
> trivial and/or my changes are pretty much a rewrite...
> 
> There's some more stuff missing from the 82371EB (e.g. USB support),
> but that's for another patch...
> 
> Boot log attached.

Forgot before, this looks good to me:

Acked-by: Corey Osgood <corey_osgood at verizon.net>

Just one question though:

>  #define PCI_DEVICE_ID_INTEL_82371AB	0x7111
>  #define PCI_DEVICE_ID_INTEL_82371AB_2	0x7112
>  #define PCI_DEVICE_ID_INTEL_82371AB_3	0x7113
> +#define PCI_DEVICE_ID_INTEL_82371AB_ISA		0x7110
> +#define PCI_DEVICE_ID_INTEL_82371AB_IDE		0x7111
> +#define PCI_DEVICE_ID_INTEL_82371AB_USB		0x7112
> +#define PCI_DEVICE_ID_INTEL_82371AB_ACPI	0x7113 /* Same as SMB */
> +#define PCI_DEVICE_ID_INTEL_82371AB_SMB		0x7113 /* Same as ACPI */

Why add these and not remove the old ones? I can already hear someone
complaining about syncing up with the linux version, but I don't think
v2 will ever do that again, and why should we be cursed with linux's
obstrufication?

-Corey