[LinuxBIOS] [Patch] Fix processor name string for Rev. F CPUs

Stefan Reinauer stepan at coresystems.de
Mon May 21 23:21:23 CEST 2007


* Ward Vandewege <ward at gnu.org> [070521 22:25]:
> On Fri, May 04, 2007 at 08:56:20PM +0200, Sven Kapferer wrote:
> > This patch fixes the processor name string for Rev F. CPUs.
> > It moves the complete naming functionality to
> > src/cpu/amd/model_fxx/processor_name.c
> > 
> > Signed-off-by: Sven Kapferer <skapfere at rumms.uni-mannheim.de>
> 
> Acked-by: Ward Vandewege <ward at gnu.org>
> 
> I've tested this on the m57sli-s4, and it fixes the processor name string (if
> K8_REV_F_SUPPORT=1 is set in Options.lb).

Does it make sense to have the code decide during runtime rather than
during compile time what to do? REV_F_SUPPORT is somewhat misleading, it
should rather say SOCKET_AM2 or SOCKET_WHATEVER_HAS_REV_F_IN_IT to make
the decision require less knowledge from people porting boards.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/




More information about the coreboot mailing list