[LinuxBIOS] r2670 - in trunk/LinuxBIOSv2/src/mainboard: asus/p2b bitworks/ims densitron/dpx114 via/epia via/epia-m

[Stefan Reinauer]

* Uwe Hermann <uwe at hermann-uwe.de> [070515 17:46]:
> On Tue, May 15, 2007 at 12:28:55PM +0200, Peter Stuge wrote:
> > On Tue, May 15, 2007 at 10:26:54AM +0000, svn at openbios.org wrote:
> > >  static inline int spd_read_byte(unsigned device, unsigned address)
> > >  {
> > > -	uint8_t c;
> > > -	c = smbus_read_byte(device, address);
> > > -	return c;
> > > +	return smbus_read_byte(device, address);
> > 
> > Should they return uint8_t perhaps?
> 
> Yes, I think so. AFAIK smbus works with byte values (or at least
> smbus_read_byte() does), and SPD data consists of bytes, too...

Most other romcc functions have no sized variables, but just
signed/unsigned. 

I would assume spd_read_byte should be at least unsigned though. 

Can anyone confirm romcc creates different code if you choose uint8_t or
unsigned or unsigned int as a return type?

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/