[LinuxBIOS] r2664 - in trunk/LinuxBIOSv2: src/mainboard/amd/norwich targets/amd/norwich

Uwe Hermann uwe at hermann-uwe.de
Tue May 15 17:51:36 CEST 2007


On Mon, May 14, 2007 at 01:40:43PM +0200, Stefan Reinauer wrote:
> * svn at openbios.org <svn at openbios.org> [070514 13:34]:
> > Modified: trunk/LinuxBIOSv2/src/mainboard/amd/norwich/failover.c
> > ===================================================================
> > --- trunk/LinuxBIOSv2/src/mainboard/amd/norwich/failover.c	2007-05-11 19:23:57 UTC (rev 2663)
> > +++ trunk/LinuxBIOSv2/src/mainboard/amd/norwich/failover.c	2007-05-14 11:33:41 UTC (rev 2664)
> > @@ -8,24 +8,5 @@
> >  
> >  static unsigned long main(unsigned long bist)
> >  {
> > -#if 0
> > -	/* This is the primary cpu how should I boot? */
> > -	if (do_normal_boot()) {
> > -		goto normal_image;
> > -	} else {
> > -		goto fallback_image;
> > -	}
> > -      normal_image:
> > -	asm volatile ("jmp __normal_image":	/* outputs */
> > -		      :"a" (bist)	/* inputs */
> > -		      :		/* clobbers */
> > -	    );
> > -      cpu_reset:
> > -	asm volatile ("jmp __cpu_reset":	/* outputs */
> > -		      :"a" (bist)	/* inputs */
> > -		      :		/* clobbers */
> > -	    );
> > -      fallback_image:
> > -#endif
> >  	return bist;
> >  }
>  
> Please rather fix then delete code like this. 
> 
> By deleting it you just manifest that nobody will ever fix this, as
> nobody will check the history.

Yeah, it should be fixed maybe, but I'd rather not do it myself as I
cannot test whether it actually works. Someone with the proper hardware
should do it, IMHO (and then also add the proper copyright+license header).


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070515/d69b3f83/attachment.sig>


More information about the coreboot mailing list