[LinuxBIOS] r2670 - in trunk/LinuxBIOSv2/src/mainboard: asus/p2b bitworks/ims densitron/dpx114 via/epia via/epia-m

Uwe Hermann uwe at hermann-uwe.de
Tue May 15 17:46:50 CEST 2007


On Tue, May 15, 2007 at 12:28:55PM +0200, Peter Stuge wrote:
> On Tue, May 15, 2007 at 10:26:54AM +0000, svn at openbios.org wrote:
> >  static inline int spd_read_byte(unsigned device, unsigned address)
> >  {
> > -	uint8_t c;
> > -	c = smbus_read_byte(device, address);
> > -	return c;
> > +	return smbus_read_byte(device, address);
> 
> Should they return uint8_t perhaps?

Yes, I think so. AFAIK smbus works with byte values (or at least
smbus_read_byte() does), and SPD data consists of bytes, too...


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070515/e2cfaab1/attachment.sig>


More information about the coreboot mailing list