[LinuxBIOS] [PATCH] adm1027.c fan control

[Marc Jones]

Ward Vandewege wrote:
> On Sat, May 12, 2007 at 02:33:55PM +0200, Stefan Reinauer wrote:
>> * Ward Vandewege <ward at gnu.org> [070511 23:35]:
>>> On Fri, May 11, 2007 at 02:25:08PM -0700, yhlu wrote:
>>>> how about other MB not connect all of FAN etc.?
>>>> or they will need other threshold for PWM?
>>> OK, fair enough. Perhaps it is better to keep this kind of thing mainboard
>>> specific.
>>>
>>> I'll work on moving the code to mainboard.c file.
>> Does it make sense to have an API letting the mainboard specific code
>> interface the component? Maybe even setting the FANs and threshold in
>> the config.lb file? 
> 
> I think that could be very helpful. What kind of syntax do you have in mind?
> 
> It could potentially get a bit complicated; the Tyan s2881 for instance has 2
> different HWM chips, each driving a number of fans and hooked up to different
> temperature sensors.
> 
> Thanks,
> Ward.
> 

I agree with Ward. Config.lb is complicated enough. I would rather see a 
  user setup function that gets called from mainboard.c with the 
appropriate thresholds.
Marc


-- 
Marc Jones
Senior Software Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors