[LinuxBIOS] Adding IGEL-316 mainboard

[Uwe Hermann]

On Sat, May 12, 2007 at 02:28:04PM +0200, Stefan Reinauer wrote:
> * Uwe Hermann <uwe at hermann-uwe.de> [070512 09:56]:
> > > Index: LinuxBIOSv2/src/mainboard/igel/igel-316/cmos.layout
> > > ===================================================================
> > > --- /dev/null
> > > +++ LinuxBIOSv2/src/mainboard/igel/igel-316/cmos.layout
> > 
> > Is this needed or used at the moment? Otherwise please drop it for now
> > (needs some adaptions in Config.lb otherwise it won't compile any more).
> > We can reintroduce it when it's really needed.
>  
> No, cmos.layout is always needed, except the machine has no battery
> backed up clock. Please dont drop this 

OK, let's keep it then.


> > > + * @brief This defines CPU's core frequency in kHz
> > 
> > The @brief is not needed, we configure Doxygen to always use the first sentence
> > as short description (JavaDoc-like).
>  
> does it hurt to do it cleanly anyways?

No, but I wouldn't consider using @brief more clean. The comments are shorter
and better readable without it, IHMO (in the source; the generated
HTML output is the same of course).


> > > +++ LinuxBIOSv2/documentation/HOWTO/igel-316-howto.txt
> > 
> > Please drop this here, and create a wiki tutorial containing this info
> > (and other instructions how to get LinuxBIOS+Linux running on this
> > thin client).
>  
> I dont think I agree that this should be dropped. I do agree it should
> go to the Wiki though. 

Yes, that's what I meant :) Kill the file, stick the information in the wiki.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070512/ad549215/attachment.sig>