[LinuxBIOS] [PATCH] flashrom: board specific enables based on matching pci-ids.

[Luc Verhaegen]

On Mon, Mar 26, 2007 at 08:52:16AM +0200, Luc Verhaegen wrote:
> On Sun, Mar 25, 2007 at 06:05:51PM +0200, Luc Verhaegen wrote:
> > On Sun, Mar 25, 2007 at 01:40:23AM -0400, Corey Osgood wrote:
> > > 
> > > Luc, could you check out the PCChips M789CG for me and see if this can
> > > support it? The stock bios is an AMIBIOS (if it matters), with a VT8235M
> > > southbridge and ITE IT8705f Super I/O (docs here:
> > > http://www.iteusa.com/product_info/file/pc/IT8705F_V.0.4.1.pdf). I've
> > > tried both the epia-m and asus fixups that are currently in your patch,
> > > but neither of them worked, and I know very little about the workings of
> > > flashrom. Here's the line with my vendor ids:
> > > 
> > > { 0x1106, 0x3177, 0x1106, 0x0000,  0x1106, 0x3123, 0x1106, 0x0000,
> > > "PCChips M789CG(v3.0)", enable_flash_xxx },
> 
> Oh, PCChips, isn't that another name for Asrock isn't it? In any case, 
> that's yet another known pci-id offender.
> 
> > > 
> > > Also, should we be moving these board-specific flash fixups off into
> > > another file? I get the feeling we're going to have a lot of them in the
> > > future.
> > > 
> > > Thanks,
> > > Corey
> > > 
> > I'll hand you a bit of python in a few hours that gathers the following 
> > information.
> > * Int16 vector for AMI
> > * Dump of 0xE0000-0xFFFFF. The int16 vector should live here, and the 
> > AWDFLASH structure exists here too.
> > 
> > So a tiny bit of python will provide for AMI and AWD.
> 
> Attached.
> 
> Do send the rom to me personally, i don't think everyone on the 
> list wants to receive a 128kB file :)
> 
> Luc Verhaegen.

This dump is fully non-intrusive, and it would allow me to:
* Fix this PCChips motherboard.
* Find out whether it really is as easy under AMI as i think it is :)
  I've already seen that it's highly trivial under award/phoenix with 
  the asus board.

So the sooner you send this on, the sooner your motherboard will be 
happy and the sooner some general conclusion is reached about the flash 
enables. :)

Imho an lrmi extension is not a good option, the knowledge of flash 
enable disappears as soon as something other than the manufacturers rom 
is installed.

flashrom needs native support for each motherboard it wishes to support.

Luc Verhaegen.