[LinuxBIOS] Remaining MCP55 bits (please comment!)

Ward Vandewege ward at gnu.org
Tue Mar 27 11:43:22 CEST 2007


Hi all,

What's the status on this? It would be really great to have the MCP55 code
merged into the v2 tree.

Thanks,
Ward.


On Wed, Mar 21, 2007 at 09:06:51AM -0700, Lu, Yinghai wrote:
> Please check the comment below:
> 
> -----Original Message-----
> From: linuxbios-bounces at linuxbios.org
> [mailto:linuxbios-bounces at linuxbios.org] On Behalf Of Stefan Reinauer
> Sent: Wednesday, March 21, 2007 5:40 AM
> To: Ed Swierk
> Cc: Carl-Daniel Hailfinger; Ward Vandewege; LinuxBIOS
> Subject: Re: [LinuxBIOS] Remaining MCP55 bits (please comment!)
> 
> 
> 
> * Ed Swierk <eswierk at arastra.com> [070319 20:01]:
> > Index: src/devices/hypertransport.c
> > ===================================================================
> > --- src/devices/hypertransport.c.orig
> > +++ src/devices/hypertransport.c
> > @@ -279,20 +279,7 @@ static void ht_collapse_early_enumeratio
> >  		}
> >  		/* Has the link failed? */
> >  		if (ctrl & (1 << 4)) {
> > -			/*
> > -			 * Either the link has failed, or we have
> > -			 * a CRC error.
> > -			 * Sometimes this can happen due to link
> > -			 * retrain, so lets knock it down and see
> > -			 * if its transient
> > -			 */
> > -			ctrl |= ((1 << 4) | (1 <<8)); // Link fail + Crc
> > -			pci_write_config16(prev.dev, prev.pos +
> prev.ctrl_off, ctrl);
> > -			ctrl = pci_read_config16(prev.dev, prev.pos +
> prev.ctrl_off);
> > -			if (ctrl & ((1 << 4) | (1 << 8))) {
> > -				printk_alert("Detected error on
> Hypertransport Link\n");
> > -				return;
> > -			}
> > +			return;

-- 
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior System Administrator




More information about the coreboot mailing list