[LinuxBIOS] [RFC] v3: dts fixes and questions

Uwe Hermann uwe at hermann-uwe.de
Sat Jun 30 21:38:05 CEST 2007


Here's a patch which streamlines the dts contents a bit:

 - Every "thing" should have an "enable;" line (or am I missing some
   reason why they shouldn't?)

 - Every "thing" should have the "enable;" as first entry, if it has one.

 - Constructors should come before other stuff, but after the "enable;".

Comments?


Does the order in which variables are defined (e.g. ide0_enable) and in
which the constructors are called matter? I.e. is there a semantic
difference between

 {
        ide0_enable = "0";
        ide1_enable = "0";
        constructor = "i82371eb_constructors";
 };

and

 {
        constructor = "i82371eb_constructors";
        ide0_enable = "0";
        ide1_enable = "0";
 };

?

See patch for my proposal, but please note that it may be incorrent,
that's why I'm asking...


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v3_dts_fixes.patch
Type: text/x-diff
Size: 2946 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070630/61c81fc5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070630/61c81fc5/attachment.sig>


More information about the coreboot mailing list