[LinuxBIOS] r396 - in LinuxBIOSv3: include/arch/x86 southbridge/amd/cs5536
ron minnich
rminnich at gmail.com
Fri Jun 29 02:24:29 CEST 2007
On 6/28/07, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> On Thu, Jun 28, 2007 at 07:00:36PM +0200, svn at openbios.org wrote:
> > Modified: LinuxBIOSv3/include/arch/x86/msr.h
> > ===================================================================
> > --- LinuxBIOSv3/include/arch/x86/msr.h 2007-06-28 16:48:40 UTC (rev 395)
> > +++ LinuxBIOSv3/include/arch/x86/msr.h 2007-06-28 17:00:36 UTC (rev 396)
> > @@ -21,16 +21,15 @@
> > #define CPU_X86_MSR_H
> >
> > /* standard MSR operations, everyone has written these one hundred times */
> > -
> > -typedef struct msr_struct
> > +struct msr
> > {
> > unsigned lo;
> > unsigned hi;
>
> No 'unsigned' please, use u8, u16, u32, etc. as needed.
fixed.
>
>
> > -} msr_t;
> > +};
> >
> > -static inline msr_t rdmsr(unsigned index)
> > +static inline struct msr rdmsr(unsigned index)
> ^^^^^^^^
> Ditto
>
fixed.
> > {
> > - msr_t result;
> > + struct msr result;
> > __asm__ __volatile__ (
> > "rdmsr"
> > : "=a" (result.lo), "=d" (result.hi)
> > @@ -39,7 +38,7 @@
> > return result;
> > }
> >
> > -static inline void wrmsr(unsigned index, msr_t msr)
> > +static inline void wrmsr(unsigned index, struct msr msr)
>
> Ditto.
fixed :-)
> > + struct msr msr;
> ^^
> Two spaces where only one should be. I'll fix it one of
> these days when this patch orgy is over...
it ends very soon.
I have to update the three other targets for stage1, assuming that is
approved, and then we are done.
ron
More information about the coreboot
mailing list