[LinuxBIOS] [PATCH] Reimplementation/fixing of CS5530/CS5530A southbridge code

[Stefan Reinauer]

* Uwe Hermann <uwe at hermann-uwe.de> [070606 23:34]:
> code and had several other problems, e.g. it enabled write access to the 
> ROM (why?)

for flash updates so flashrom does not have to do it.

> +	/* TODO: Make all of this configurable? */

No, thats a worthless "option" imho. Enable as much as you can. There is
no reason not to.


> +	/* Decode 0x000E0000-0x000FFFFF (128 KB), not just 64 KB. */
> +	reg8 = pci_read_config8(dev, ROM_AT_LOGIC_CONTROL_REG);
> +	reg8 |= LOWER_ROM_ADDRESS_RANGE;
> +	pci_write_config8(dev, ROM_AT_LOGIC_CONTROL_REG, reg8);

I'd drop that and rather put ram there. LinuxBIOS does not use the <1M
space.

> +	/* Decode 0xFF000000-0xFFFFFFFF (16 MB), not just 256 KB. */
> +	reg8 = pci_read_config8(dev, ROM_AT_LOGIC_CONTROL_REG);
> +	reg8 |= UPPER_ROM_ADDRESS_RANGE;
> +	pci_write_config8(dev, ROM_AT_LOGIC_CONTROL_REG, reg8);
> +
> +	/* Set positive decode on ROM. */
> +	reg8 = pci_read_config8(dev, DECODE_CONTROL_REG2);
> +	reg8 |= BIOS_ROM_POSITIVE_DECODE;
> +	pci_write_config8(dev, DECODE_CONTROL_REG2, reg8);
> +
> +	/* TODO: Make ROM writable? As config option maybe? */

If support is in flashrom, we should not, i guess.



But.. Should the above be done in failover.c or somewhat early? If you
have fallback and normal the high space may be required a lot earlier
than this.

Good work. 

Acked-by: Stefan Reinauer <stepan at coresystems.de>

please fix above issues before or after the commit.



-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/