[LinuxBIOS] [PATCH][LAR] Allow human friendly suffixes for the size option

Peter Stuge peter at stuge.se
Thu Jul 12 01:19:53 CEST 2007

Great idea.

On Wed, Jul 11, 2007 at 12:26:16PM -0600, Jordan Crouse wrote:
> +	printf("                \tUse a 'k' suffix to multiply the size by 1K or\n");
> +	printf("                \ta 'm' suffix to multiple the size by 1M.\n");

I would prefer 1024 rather than 1K and 1048576 or 1024*1024 rather
than 1M.

> +static void parse_larsize(char *str)

static u32 ..

> +  larsize = size;

.. and return size ?

May it's useful somewhere else too? Ie. move to lib.c?


More information about the coreboot mailing list