[LinuxBIOS] [RFC] v3: dts fixes and questions

Uwe Hermann uwe at hermann-uwe.de
Tue Jul 3 01:28:14 CEST 2007


On Mon, Jul 02, 2007 at 12:38:32AM +0200, Stefan Reinauer wrote:
> * ron minnich <rminnich at gmail.com> [070701 05:48]:
> > > then? That has the benefit that you don't have to know what the default
> > > is (enabled or disabled), you know everything you need just by looking
> > > at the dts itself.
> > 
> > yeah, that works. I will take the magic enabled out of the .y, and
> > will require that people set that property for each node; I will catch
> > a missing set at flatten tree time. I think that is reasonable.
>  
> Please dont do that. I think it is reasonable to assume that a device
> that you specify is enabled. Otherwise why would you specify it? 
> 
> I dont like overspecifying completely obvious things in description files.

Yeah, I think you're right.

So we have two options:

 1. disable="1"
 2. enable="0"

for devices which should be disabled. I think option 1 is a bit
clearer. Thoughts?


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070703/69f7ef9a/attachment.sig>


More information about the coreboot mailing list