[LinuxBIOS] [PATCH] flashrom Makefile message improvements

Stefan Reinauer stepan at coresystems.de
Fri Feb 16 19:36:21 CET 2007


* Ed Swierk <eswierk at arastra.com> [070214 19:45]:
> Currently the flashrom Makefile tries to detect whether pciutils-devel
> is installed, but the test also fails if zlib-devel is missing. This
> patch changes the error message accordingly.

I would generally say this is not a problem in LinuxBIOS but in the
distribution. If building binaries using pciutils requires additional
packages, they should be required by pciutils-devel.

Which distribution is this? 

Glad it is in though, it will reduce questions.

> Signed-off-by: Ed Swierk <eswierk at arastra.com>
> 
> --Ed

> Index: LinuxBIOSv2-2552/util/flashrom/Makefile
> ===================================================================
> --- LinuxBIOSv2-2552.orig/util/flashrom/Makefile
> +++ LinuxBIOSv2-2552/util/flashrom/Makefile
> @@ -41,14 +41,14 @@ dep:
>  	@$(CC) -MM *.c > .dependencies
>  
>  pciutils:
> -	@echo; echo -n "Checking for pciutils... "
> +	@echo; echo -n "Checking for pciutils and zlib... "
>  	@$(shell ( echo "#include <pci/pci.h>";		   \
>  		   echo "struct pci_access *pacc;";	   \
>  		   echo "int main(int argc, char **argv)"; \
>  		   echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c )
>  	@$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null &&	\
>  		echo "found." || ( echo "not found."; echo;		\
> -		echo "Please install pciutils and pciutils-devel.";	\
> +		echo "Please install pciutils-devel and zlib-devel.";	\
>  		echo "See README for more information."; echo;		\
>  		rm -f .test.c .test; exit 1)
>  	@rm -f .test.c .test

> -- 
> linuxbios mailing list
> linuxbios at linuxbios.org
> http://www.openbios.org/mailman/listinfo/linuxbios

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/




More information about the coreboot mailing list