[LinuxBIOS] Sun Ultra40 patches
Stefan Reinauer
stefan.reinauer at coresystems.de
Fri Feb 2 22:12:47 CET 2007
Roman Kononov wrote:
> Rediffing with -w will not help. Fixing coding style first will not help
> either. This is not as simple as a patch. It is a major re-writing.
> The current code in the repository is half-finished and works only
> by an accident. Reviewers should apply the patch and try to understand
> what is going on there.
>
There's pretty much stuff like the following, which is obviously not one
of those parts of the major rewrite ;-)
But let me look into it some more, and get back to it.
> ## Compute the start location and size size of
> ## The linuxBIOS bootloader.
> ##
> -default PAYLOAD_SIZE = ( ROM_SECTION_SIZE - ROM_IMAGE_SIZE )
> +default PAYLOAD_SIZE = ( ROM_SECTION_SIZE - ROM_IMAGE_SIZE )
> default CONFIG_ROM_PAYLOAD_START = (0xffffffff - ROM_SIZE + ROM_SECTION_OFFSET + 1)
> -default CONFIG_ROM_PAYLOAD = 1
> +default CONFIG_ROM_PAYLOAD = 1
>
> ##
> ## Compute where this copy of linuxBIOS will start in the boot rom
> @@ -33,7 +33,7 @@ default _ROMBASE = ( CONFIG_ROM_PAY
> default XIP_ROM_SIZE=65536
> default XIP_ROM_BASE = ( _ROMBASE + ROM_IMAGE_SIZE - XIP_ROM_SIZE )
>
> -arch i386 end
> +arch i386 end
>
>
> ##
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
More information about the coreboot
mailing list