[LinuxBIOS] [PATCH] buildrom qemu patch
Uwe Hermann
uwe at hermann-uwe.de
Fri Dec 14 01:39:40 CET 2007
On Thu, Dec 13, 2007 at 04:54:44PM -0700, Myles Watson wrote:
> Index: buildrom-devel/config/platforms/Config.in
> ===================================================================
> --- buildrom-devel/config/platforms/Config.in (revision 84)
> +++ buildrom-devel/config/platforms/Config.in (working copy)
> @@ -112,15 +112,16 @@
> default n
> help
> Say 'y' here to build a patched version of QEMU to work with
> - LinuxBIOS. This downloads the correct version and patches it
> - it even builds it if you specify the QEMU_CC correctly.
> + LinuxBIOS. This downloads the correct version and patches it;
> + it even builds it if you specify the QEMU_CC correctly
Why this? You remove the full stop from the sentence, which is
incorrect. Kconfig help texts should be full sentences which end
with a full stop.
> config QEMU_CC
> string "Compiler to use when building QEMU"
> depends BUILD_QEMU
> - default "gcc32"
> + default "gcc34"
> help
> - Set this string to point to your compiler (GCC_VER <=3.2)
> + qemu has known problems when built using gcc 4.x
> + Set this string to point to your compiler (GCC_VER 3.x)
Ditto, should end with full stop.
Uwe.
--
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot
mailing list