[LinuxBIOS] Buildrom remove lgdt patch

Jordan Crouse jordan.crouse at amd.com
Thu Dec 13 18:55:38 CET 2007


On 13/12/07 08:00 -0700, Myles Watson wrote:
> This patch removes the option from buildrom to use the lgdt patch for
> LinuxBIOSv3.
> 
> On a compiler that doesn't need the patch, this patch makes the image
> unbootable.
> 
> Signed-off-by: Myles Watson <myles at pel.cs.byu.edu>
Acked-by: Jordan Crouse <jordan.crouse at amd.com>

> Index: buildrom-devel/Config.in
> ===================================================================
> --- buildrom-devel/Config.in	(revision 83)
> +++ buildrom-devel/Config.in	(working copy)
> @@ -54,16 +54,6 @@
>  	help
>  	  Use the v3 tree.  LinuxBIOSv3 doesn't support all platforms yet.
>  
> -config LINUXBIOS_V3_LGDT_PATCH
> -	bool "Avoid an error in stage0_i586 with some compilers"
> -	depends LINUXBIOS_V3
> -	default n
> -	help
> -	  Say 'y' here to use the patch from the mailing list to replace 
> -	  "data32  lgdt %cs:gdtptr" with 
> -	  "movl $gdtptr"
> -          "%ebx lgdt %cs:(%bx)"
> -
>  config USE_LZMA
>  	bool "Enable LZMA compression"
>  	depends !PAYLOAD_OFW
> Index: buildrom-devel/packages/linuxbios/patches/lgdt.patch
> ===================================================================
> --- buildrom-devel/packages/linuxbios/patches/lgdt.patch	(revision 83)
> +++ buildrom-devel/packages/linuxbios/patches/lgdt.patch	(working copy)
> @@ -1,14 +0,0 @@
> -Index: svn/arch/x86/stage0_i586.S
> -===================================================================
> ---- svn/arch/x86/stage0_i586.S	(revision 539)
> -+++ svn/arch/x86/stage0_i586.S	(working copy)
> -@@ -56,7 +56,8 @@
> - 	 * the ld hackery and other things. So leave it as is with this comment. 
> - 	 */
> - 
> --	data32	lgdt %cs:gdtptr
> -+	movl	$gdtptr, %ebx
> -+	lgdt	%cs:(%bx)
> - 
> - 	movl	%cr0, %eax
> - 	andl	$0x7FFAFFD1, %eax /* PG,AM,WP,NE,TS,EM,MP = 0 */
> Index: buildrom-devel/packages/linuxbios/qemu.mk
> ===================================================================
> --- buildrom-devel/packages/linuxbios/qemu.mk	(revision 83)
> +++ buildrom-devel/packages/linuxbios/qemu.mk	(working copy)
> @@ -17,9 +17,6 @@
>  ifeq ($(CONFIG_LINUXBIOS_V3),y)
>  	LINUXBIOS_URL=svn://linuxbios.org/repository/LinuxBIOSv3
>  	LINUXBIOS_TARBALL=linuxbiosv3-svn-$(LINUXBIOS_TAG).tar.gz
> -	ifeq ($(CONFIG_LINUXBIOS_V3_LGDT_PATCH),y)
> -	LINUXBIOS_PATCHES += $(PACKAGE_DIR)/linuxbios/patches/lgdt.patch
> -	endif
>  	LINUXBIOS_SVN_DIR=$(SOURCE_DIR)/linuxbiosv3
>  else
>  	ifeq ($(CONFIG_PAYLOAD_LAB),y)


-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.






More information about the coreboot mailing list