[LinuxBIOS] LinuxBIOSv3 lgdt and gdtptr patch

Myles Watson myles at pel.cs.byu.edu
Tue Dec 11 19:37:32 CET 2007


> > > > It was submitted (but not in patch form) by Brendan Trotter
> > > > http://www.mail-archive.com/linuxbios@linuxbios.org/msg08771.html
> > > >
> > > > Here it is in patch form.
> > > > -	data32	lgdt %cs:gdtptr
> > > > +	movl	$gdtptr, %ebx
> > > > +	lgdt	%cs:(%bx)
> > > >
> > > > It removes the first line, which causes some compilers to give a
> > > > "truncated gdtptr" error, and replaces it with an intermediate load
> > > > step. I think it should be tested by someone with the "working"
> > > > compiler, to compare the output.
> > >
> > > Please repost with a Signed-off-by.
> >
> > I was hoping Brendan Trotter would supply that, since it was his work.
> It
> > could be considered trivial, though, if the compiler output is the same.
> 
> Yes, I guess this is trivial enough so you can post it with your
> Signed-off-by, but if Brendan (CC'd) can re-send with a Signed-off-by
> that's fine too, of course.

I tried it on a different compiler (4.1.1) and the patch builds, but won't
boot on qemu.  Without the patch it builds and boots.

I'll just upgrade my compiler.

Myles 







More information about the coreboot mailing list