[LinuxBIOS] [PATCH] v3: Crash with a descriptive message in case of compiler bugs

[Stefan Reinauer]

Carl-Daniel Hailfinger wrote:
> On 30.11.2007 18:35, Carl-Daniel Hailfinger wrote:
>   
>> Ron mentioned he had strange hangs in pll_reset on various targets. This
>> may be due to miscompilation of XIP objects which do not have
>> _MAINBOBJECT defined. This issue was impossible to see on qemu because
>> no such object existed. Introduce initram_printktest.c in the Qemu
>> target, which will test for miscompilation and crash with a descriptive
>> error message.
>>
>> This has been build tested and runtime tested on Qemu, and with my
>> compiler/linker combination it indeed crashes.
>> gcc (GCC) 4.2.1 (SUSE Linux)
>> GNU ld (GNU Binutils) 2.17.50.20070726-14 (SUSE Linux)
>>
>> Trying with gcc-4.1 (GCC) 4.1.3 20070724 (prerelease) (SUSE Linux) and
>> the linker above had exactly the same results.
>>
>> Unless we manage to fix the bug uncovered by this patch, leaving the
>> Qemu target in crashing state is the best thing we can do because this
>> behaviour mirrors the state of all other targets.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>
>> (don't forget "svn add mainboard/emulation/qemu-x86/initram_printktest.c"
>> if you commit)
>>   
>>     
>
> Ack anyone? I have another patch which fixes the bug revealed by this
> patch, but I want to commit them in separate steps to make it more
> obvious that one patch points out the problem, and one is a possible
> solution.
>
>
> Regards,
> Carl-Daniel
>
>   
I think this is rather an experiment and should not be committed in this
way. It's not a functionality of LinuxBIOS. Do we really need this?

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20071201/788c3f12/attachment.sig>