[LinuxBIOS] patch: extending LAR, and removing elf from linuxbios (it is not needed)

ron minnich rminnich at gmail.com
Tue Aug 28 17:12:39 CEST 2007


On 8/28/07, Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> Can we change the MAGIC to some less likely string, perhaps even with
> version info? A lot of filesystems have mixed-case magic strings, for
> example ReiserFS has "ReIsErFs" or "ReIsEr2Fs" or "ReIsEr3Fs". Nobody is
> going to include such a string by accident in his code.

That's not the real problem. The real problem is that if you do this:
char *c = MAGIC;

Then that string is in the data space of linuxbois. If it ever gets to
be 16-byte aligned, the find_file in lar will think it has found  a
header. I just realized stefan's fix might solve the problem. But we
can add his fix later.

ron




More information about the coreboot mailing list