[LinuxBIOS] [PATCH] flashrom patch for iwill dk8_htx
libv at skynet.be
Sat Apr 28 14:17:08 CEST 2007
On Sat, Apr 28, 2007 at 02:00:42AM +0200, Uwe Hermann wrote:
> On Fri, Apr 27, 2007 at 10:33:53PM +0200, Luc Verhaegen wrote:
> > On Fri, Apr 27, 2007 at 04:44:10PM +0200, Mondrian Nuessle wrote:
> > > Actually you do not need to set the index reg twice. I just used the
> > > code pattern from the Agami Aruma board, which does the same thing...
> > In that case, we should introduce functions like:
> > void w83xxx_ext_enter(void);
> > void w83xxx_ext_leave(void);
> > /* Enter extended functions before using these! */
> > unsigned char w83xxx_ext_read(unsigned char index);
> > void w83xxx_ext_write(unsigned char index, unsigned char data);
> > void w83xxx_ext_mask(unsigned char index, unsigned char data,
> > unsigned char mask);
> Hm, not sure. Looks a bit like overkill in this case.
Three out of four functions in there (when mondrians patch finally gets
in) would make use of this already. That says something about what
future board enables will look like too.
This isn't overkill in any way, it's formalizing what's there.
Without mondrians code:
board_enable.c | 137 +++++++++++++++++++++++++++++++-------------------------- 1 file
changed, 76 insertions(+), 61 deletions(-)
So when mondrians patch is in there, this is made up for completely, and
the board enables really are a lot friendlier.
More information about the coreboot